8271456: Avoid looking up standard charsets in "java.desktop" module

[TimPushkin]

Backport of JDK-8271456 from JDK 17, for parity with Oracle 11.0.26.

There were trivial conflicts in copyright years and imports in a few files.

Testing: GitHub CI, jdk_imageio test group locally (mac/arm64)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8271456 needs maintainer approval

Issue

• JDK-8271456: Avoid looking up standard charsets in "java.desktop" module (Enhancement - P4 - Approved)

Reviewers

• Alexey Bakhtin (@alexeybakhtin - Reviewer)
• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3081/head:pull/3081
$ git checkout pull/3081

Update a local copy of the PR:
$ git checkout pull/3081
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3081/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3081

View PR using the GUI difftool:
$ git pr show -t 3081

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3081.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TimPushkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8271456: Avoid looking up standard charsets in "java.desktop" module

Reviewed-by: abakhtin, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 7c21bad: 8299748: java/util/zip/Deinflate.java failing on s390x
• 156d998: 8224087: Compile C code for at least C99 Standard compliance
• 26a8aca: 8354941: Build failure with glibc 2.42 due to uabs() name collision
• ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/37123ee7a5058ec81f2ef85a68fe9ae43b0ba216...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeybakhtin, @jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (02e544e5)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[alexeybakhtin]

Looks good to me. Almost clean backport with minimum trivial changes

[openjdk]

⚠️ @TimPushkin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[TimPushkin]

JDI test failures do not seem related to the change: the change only affects jdk.desktop module which is not related to the failing jdk.jdi module. JDK-8336451 reads like it was tracking this issue but is was closed as solved a year ago, there is a bunch of similar issues in JBS, not sure if there is one that tracks this exact issue again already.

#3082, which depends on this PR, passed the CI (i.e. the issue is probably intermittent), while unrelated #3077 has exactly the same issue (i.e. the issue is not related to this particular change).

So I don't think anything in this PR should be fixed.

[TimPushkin]

/approval Backporting for parity with Oracle and to make dependent in-progress backports cleaner.
Lower medium risk. The change is a cleanup limited to jdk.desktop, it should not change the behavior. It has been running in newer LTS releases for a while now. Conflicts were trivial (copyright years, imports).
Testing: GitHub CI, jdk_imageio test group locally (mac/arm64).

[openjdk]

@TimPushkin usage: /approval [<id>] (request|cancel) [<text>]

[TimPushkin]

/approval request Backporting for parity with Oracle and to make dependent in-progress backports cleaner.
Lower medium risk. The change is a cleanup limited to jdk.desktop, it should not change the behavior. It has been running in newer LTS releases for a while now. Conflicts were trivial (copyright years, imports).
Testing: GitHub CI, jdk_imageio test group locally (mac/arm64).

[openjdk]

@TimPushkin
8271456: The approval request has been created successfully.

[jerboaa]

Looks OK.

[TimPushkin]

/integrate

[openjdk]

@TimPushkin
Your change (at version 02e544e) is now ready to be sponsored by a Committer.

[alexeybakhtin]

/sponsor

[openjdk]

Going to push as commit 2721380.
Since your change was applied there have been 8 commits pushed to the master branch:

• 7c21bad: 8299748: java/util/zip/Deinflate.java failing on s390x
• 156d998: 8224087: Compile C code for at least C99 Standard compliance
• 26a8aca: 8354941: Build failure with glibc 2.42 due to uabs() name collision
• ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/37123ee7a5058ec81f2ef85a68fe9ae43b0ba216...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeybakhtin @TimPushkin Pushed as commit 2721380.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.