-
Notifications
You must be signed in to change notification settings - Fork 253
8213781: web page background renders blue in JEditorPane #3118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @TheMangovnik, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user TheMangovnik" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issues from the original commit. |
|
/covered |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
|
|
/approval request Clean back port fixing background rendering for some webpages when JEditorPane is used. Tests run on fedora 43. Gtests passed, same T1 failing before and after the backport - not related to this issue. |
|
@TheMangovnik |
Backport of JDK-8213781 - web page background renders blue in JEditorPane
Fixing JEditorPane that for some webpages renders the background blue instead white. E.g. http://www.google.com/
Clean backport.
Passed tier1 tests. Existing failures are the same as on the unpatched code, they are unrelated.
Passed gtests.
GH Actions are passing.
Progress
Warning
8213781: web page background renders blue in JEditorPaneIssues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3118/head:pull/3118$ git checkout pull/3118Update a local copy of the PR:
$ git checkout pull/3118$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3118/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3118View PR using the GUI difftool:
$ git pr show -t 3118Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3118.diff
Using Webrev
Link to Webrev Comment