-
Notifications
You must be signed in to change notification settings - Fork 251
8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@wkia The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@wkia The pull request is being re-evaluated and the inactivity timeout has been reset. |
This is backport of "JDK-8365098 make/RunTests.gmk generates a wrong path to test artifacts on Alpine" as JDK11 tests have the same issue on Alpine - generate a wrong path to test artifacts.
However, there are still vendors which still build jdk11 and below for Solaris, so I added the cross platfrom fix here, using a combination of SED and TR.
So, the backport isn't clean. (Build system fix, test artifacts path processing.)
I'm not sure, if I may request for integration as a backport, or should I create new JBS bug to cover this (starting from the upstream).
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3125/head:pull/3125$ git checkout pull/3125Update a local copy of the PR:
$ git checkout pull/3125$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3125/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3125View PR using the GUI difftool:
$ git pr show -t 3125Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3125.diff
Using Webrev
Link to Webrev Comment