8342075: HttpClient: improve HTTP/2 flow control checks

[GoeLin]

I backport this for parity with 17.0.17-oracle based on the change in 21.

src/java.net.http/share/classes/jdk/internal/net/http/Stream.java
Two trivial resolves due to context.

src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java

Resolved because 8308310: HttpClient: Avoid logging or locking from within synchronized blocks
is not in 17.

src/java.net.http/share/classes/module-info.java
Omitted, as "8296804: Document HttpClient configuration properties in java.net.http module-info"
is not in 17. The CSR for 17 documents that this is dropped.

Follow ups are on the list of backports I will do.
Blocking changes all already in 17.

I had to adapt ConnectionFlowControlTest.java and StreamFlowControlTest.java because HttpClient does not
implement AutoClosable / shutdownNow() / close() in 17.
I also amended the @build instructions in StreamFlowControlTest.java.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8342075 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8351085 to be approved

Issues

• JDK-8342075: HttpClient: improve HTTP/2 flow control checks (Bug - P4 - Approved)
• JDK-8351085: HttpClient: improve HTTP/2 flow control checks (CSR)

Reviewers

• Alexey Bakhtin (@alexeybakhtin - Reviewer) Review applies to 211a4553
• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3786/head:pull/3786
$ git checkout pull/3786

Update a local copy of the PR:
$ git checkout pull/3786
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3786

View PR using the GUI difftool:
$ git pr show -t 3786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3786.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342075: HttpClient: improve HTTP/2 flow control checks

Reviewed-by: rschmelter, abakhtin
Backport-of: 32ac3e713ea4370e496717967fff7de9450d2f69

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 7845f08: 8357253: Test test/jdk/sun/security/ssl/SSLSessionImpl/ResumeClientTLS12withSNI.java writes in src dir
• 6d190cb: 8350830: Values converted incorrectly when reading TLS session tickets
• 70b4f5b: 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension
• ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/ef27cae10a214e0c81820b9abe7fa5a9bc5016ef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 04: Full (f9cbc600)
• 03: Full - Incremental (073bb3d5)
• 02: Full - Incremental (c86d9d24)
• 01: Full (3349b52e)
• 00: Full (211a4553)

[alexeybakhtin]

Thank you for the backport! The changes look good to me

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[GoeLin]

HI @alexeybakhtin
I saw in #3298 that you are using a ThreadPool in the tests.
I think this is a useful improvement. Should I add that to my change here?

[alexeybakhtin]

HI @alexeybakhtin I saw in #3298 that you are using a ThreadPool in the tests. I think this is a useful improvement. Should I add that to my change here?

Yes, I forgot about these changes. I think they could be useful here to clean up resources.

[GoeLin]

Thanks, I added them.

[schmelter-sap]

Looks good.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Thanks for the review!

[GoeLin]

/integrate

[openjdk]

Going to push as commit 4addb57.
Since your change was applied there have been 15 commits pushed to the master branch:

• 7845f08: 8357253: Test test/jdk/sun/security/ssl/SSLSessionImpl/ResumeClientTLS12withSNI.java writes in src dir
• 6d190cb: 8350830: Values converted incorrectly when reading TLS session tickets
• 70b4f5b: 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension
• ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/ef27cae10a214e0c81820b9abe7fa5a9bc5016ef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 4addb57.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.