Skip to content

8185429: [macos] After a modal dialog is closed, no window becomes active #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 12, 2025

I backport this for parity with 17.0.17-oracle.

Resolve Copyright, probably clean.

ProblemListed test passes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8185429 needs maintainer approval

Issue

  • JDK-8185429: [macos] After a modal dialog is closed, no window becomes active (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3836/head:pull/3836
$ git checkout pull/3836

Update a local copy of the PR:
$ git checkout pull/3836
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3836/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3836

View PR using the GUI difftool:
$ git pr show -t 3836

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3836.diff

Using Webrev

Link to Webrev Comment

@GoeLin GoeLin marked this pull request as draft August 12, 2025 12:04
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 12, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8185429: [macos] After a modal dialog is closed, no window becomes active

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 3a26bbcebc2f7d11b172f2b16192a3adefeb8111 8185429: [macos] After a modal dialog is closed, no window becomes active Aug 12, 2025
@openjdk
Copy link

openjdk bot commented Aug 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 12, 2025
@GoeLin GoeLin closed this Aug 13, 2025
@GoeLin GoeLin reopened this Aug 13, 2025
@GoeLin GoeLin marked this pull request as ready for review August 13, 2025 06:15
@openjdk
Copy link

openjdk bot commented Aug 13, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval Requires approval; will be removed when approval is received labels Aug 13, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant