Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 16, 2025

Hi all,

This pull request contains a backport of commit fa5ad700 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 19 Jul 2024 and was reviewed by Leonid Mesnik and Serguei Spitsyn.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334771 needs maintainer approval

Issue

  • JDK-8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4053/head:pull/4053
$ git checkout pull/4053

Update a local copy of the PR:
$ git checkout pull/4053
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4053/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4053

View PR using the GUI difftool:
$ git pr show -t 4053

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4053.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fa5ad700bb6a92aef7577969e09b4fbd93feb388 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137 Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to increase the max heap size which make test more robustness. I want to backprt this becase this will make later backport(JDK-8343340) cleanly. Change has been verified locally on linux-x64, which the swap memory is enbale. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

@sendaoYan
8334771: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant