Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 18, 2025

Backport of the change in 21.

Resolved one import in test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java.

Unfortunately I had to omit patching test/jdk/tools/jpackage/share/AddLShortcutTest.java
which is not in 17.

I had to keep the import of java.awt.Desktop in PackageTest.java to make it compile.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343875 needs maintainer approval

Issue

  • JDK-8343875: Minor improvements of jpackage test library (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4071/head:pull/4071
$ git checkout pull/4071

Update a local copy of the PR:
$ git checkout pull/4071
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4071

View PR using the GUI difftool:
$ git pr show -t 4071

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4071.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@GoeLin GoeLin changed the base branch from master to pr/4070 October 18, 2025 18:22
@GoeLin GoeLin changed the title Goetz backport 8343875 backport 2cdc9ed6d687cee343a5792a066a24839c6baccf Oct 18, 2025
@openjdk openjdk bot changed the title backport 2cdc9ed6d687cee343a5792a066a24839c6baccf 8343875: Minor improvements of jpackage test library Oct 18, 2025
@openjdk
Copy link

openjdk bot commented Oct 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 18, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2025

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/4070 to master October 20, 2025 12:27
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8343875
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant