Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 20, 2025

I backport this for parity with 17.0.18-oracle

Based on the push to 21. Trivial resolves, probably clean anyways.

Needed to resolve these as "8283698: Refactor Locale constructors used in src/test" is only in 19.
test/jdk/java/text/Format/DateFormat/bug4358730.java
Resolved time zone string.
test/jdk/java/util/PluggableLocale/TimeZoneNameProviderTest.java
Copyright
test/jdk/sun/util/resources/TimeZone/Bug4640234.java
Copyright

Several changes missing in 17:
test/jdk/sun/security/x509/X509CertImpl/V3Certificate.java
Copyright


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8347841 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347841: Test fixes that use deprecated time zone IDs (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4073/head:pull/4073
$ git checkout pull/4073

Update a local copy of the PR:
$ git checkout pull/4073
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4073/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4073

View PR using the GUI difftool:
$ git pr show -t 4073

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4073.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@GoeLin GoeLin changed the title backport from 21 backport 50537aefc736db43e4b08133dcd181ba69f10e8d Oct 20, 2025
@openjdk openjdk bot changed the title backport 50537aefc736db43e4b08133dcd181ba69f10e8d 8347841: Test fixes that use deprecated time zone IDs Oct 20, 2025
@openjdk
Copy link

openjdk bot commented Oct 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 20, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant