8354893: [REDO BACKPORT] javac crashes while adding type annotations to the return type of a constructor (JDK-8320001)

[cushon]

This is a backport of JDK-8354893, which is a follow-up to JDK-8341779.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8354893 needs maintainer approval

Integration blocker

 ⚠️ Dependency #4150 must be integrated first

Issue

• JDK-8354893: [REDO BACKPORT] javac crashes while adding type annotations to the return type of a constructor (JDK-8320001) (Bug - P2)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4151/head:pull/4151
$ git checkout pull/4151

Update a local copy of the PR:
$ git checkout pull/4151
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4151

View PR using the GUI difftool:
$ git pr show -t 4151

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4151.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into pr/4150 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (77e924e8)

[bridgekeeper]

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[cushon]

/touch

[openjdk]

@cushon The pull request is being re-evaluated and the inactivity timeout has been reset.

[vicente-romero-oracle]

lgtm