-
Notifications
You must be signed in to change notification settings - Fork 231
8337681: PNGImageWriter uses much more memory than necessary #4187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
|
@cost0much This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Fixes issue with the PNGImageWriter making unnecessary copies of raster and data buffers when PNG images are written. Already backported to 21.0.8 and applies cleanly from JDK24. Passes GHA. Risk is low as client-lib change + previous 21 backport has gone multiple releases without issue. |
|
@cost0much |
|
/integrate |
|
@cost0much |
Clean backport. Fixes issue with the PNGImageWriter making unnecessary copies of raster and data buffers when PNG images are written. Passes GHA. Added test passes.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4187/head:pull/4187$ git checkout pull/4187Update a local copy of the PR:
$ git checkout pull/4187$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4187/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4187View PR using the GUI difftool:
$ git pr show -t 4187Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4187.diff
Using Webrev
Link to Webrev Comment