Skip to content

Conversation

@jyma22
Copy link

@jyma22 jyma22 commented Dec 5, 2025

Hi all,

This pull request contains a backport of commit d4d1fbc2 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on Mar 3, 2022 and was reviewed by Albert Mingkun Yang and Ivan Walulya.

This PR depends on #3992, so the target would be changed from pr/3992 to master once pr/3992 is approved and merged.

Testing: jtreg 1-3 gha

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8282484 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8282484: G1: Predicted old time in log always zero (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4205/head:pull/4205
$ git checkout pull/4205

Update a local copy of the PR:
$ git checkout pull/4205
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4205

View PR using the GUI difftool:
$ git pr show -t 4205

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4205.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2025

👋 Welcome back jyma22! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@jyma22 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282484: G1: Predicted old time in log always zero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 202 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d4d1fbc27a2382d8d9545b7bf672cdcc81654404 8282484: G1: Predicted old time in log always zero Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2025

Webrevs

@jyma22
Copy link
Author

jyma22 commented Dec 5, 2025

/approval request Backporting this patch fixes the log output to accurately report the expected time required to process the initial set of old gen regions.
Path applies cleanly to 17u, but requires JDK-8306444 to be applied first through #3992.
Included test passes. Ran tier1-3.

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@jyma22
8282484: Approval has already been requested and approved.

@jyma22
Copy link
Author

jyma22 commented Dec 5, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@jyma22
Your change (at version 6fbbf23) is now ready to be sponsored by a Committer.

@jyma22
Copy link
Author

jyma22 commented Dec 5, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@jyma22 Only Committers are allowed to sponsor changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored

Development

Successfully merging this pull request may close these issues.

1 participant