Skip to content

8351458: (ch) Move preClose to UnixDispatcher #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shruacha1234
Copy link

@shruacha1234 shruacha1234 commented Aug 5, 2025

OpenJDK PR: openjdk/jdk#23956
OpenJDK bug: https://bugs.openjdk.org/browse/JDK-8351458

The original patch didn’t apply cleanly to the JDK21u-dev branch due to a copyright header mismatch. However, the rest of the changes were ported without issues. Manually updated the copyright header to resolve the conflict.


Progress

  • JDK-8351458 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351458: (ch) Move preClose to UnixDispatcher (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2051/head:pull/2051
$ git checkout pull/2051

Update a local copy of the PR:
$ git checkout pull/2051
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2051

View PR using the GUI difftool:
$ git pr show -t 2051

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2051.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2025

👋 Welcome back sacharya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@shruacha1234 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@shruacha1234 shruacha1234 changed the title Backport 0de2cddf3a7be23f67af93972875af1235f3107e 8351458: (ch) Move preClose to UnixDispatcher Aug 6, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 6, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 6, 2025

Webrevs

@shruacha1234
Copy link
Author

shruacha1234 commented Aug 6, 2025

/approval JDK-8351458 request Clean backport, Refactored to move "prepare for close" logic into UnixDispatcher to simplify code and handle blocked threads during socket close more effectively in 21u-dev.

@openjdk
Copy link

openjdk bot commented Aug 6, 2025

@shruacha1234
JDK-8351458: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 6, 2025
@shruacha1234 shruacha1234 changed the title 8351458: (ch) Move preClose to UnixDispatcher Backport cabd1fa3863b1fced596889fd15e197d2ee96b19 Aug 6, 2025
@openjdk
Copy link

openjdk bot commented Aug 6, 2025

⚠️ @shruacha1234 the commit cabd1fa3863b1fced596889fd15e197d2ee96b19 does not refer to an issue in project JDK.

@shruacha1234 shruacha1234 changed the title Backport cabd1fa3863b1fced596889fd15e197d2ee96b19 Backport 0de2cddf3a7be23f67af93972875af1235f3107e Aug 6, 2025
@openjdk openjdk bot changed the title Backport 0de2cddf3a7be23f67af93972875af1235f3107e 8351458: (ch) Move preClose to UnixDispatcher Aug 6, 2025
@openjdk
Copy link

openjdk bot commented Aug 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Aug 6, 2025
@openjdk
Copy link

openjdk bot commented Aug 6, 2025

@shruacha1234 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Aug 6, 2025
@jerboaa
Copy link
Contributor

jerboaa commented Aug 6, 2025

@shruacha1234 Please read https://openjdk.org/projects/jdk-updates/approval.html

In particular in Rule 1 it says:

[...] In that comment the requester must describe why it's important
to fix this bug, explain the nature of the fix, estimate its risk and describe
its test coverage. [...]

Nothing like that is in the existing fix request comment.

@openjdk
Copy link

openjdk bot commented Aug 7, 2025

⚠️ @shruacha1234 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants