Skip to content

8352860: Open source events tests batch0 #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Aug 13, 2025

Backporting JDK-8352860: Open source events tests batch0. Adds two event tests - one testing click events, and the other testing window active events. Ran GHA Sanity Checks, local Tier 1 and 2, and new tests directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352860 needs maintainer approval

Issue

  • JDK-8352860: Open source events tests batch0 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2091/head:pull/2091
$ git checkout pull/2091

Update a local copy of the PR:
$ git checkout pull/2091
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2091

View PR using the GUI difftool:
$ git pr show -t 2091

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2091.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d4d18350f367a18813d0d418169e852c1530418e 8352860: Open source events tests batch0 Aug 13, 2025
@openjdk
Copy link

openjdk bot commented Aug 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 13, 2025
@openjdk
Copy link

openjdk bot commented Aug 13, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 13, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8352860: Open source events tests batch0

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2 and new manual tests. Patch is clean. Although change has only been present in tip since March, 2025, change has been accepted by Oracle (and tests were previously closed source).

@openjdk
Copy link

openjdk bot commented Aug 14, 2025

@satyenme
8352860: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant