8365893: test/jdk/java/lang/Thread/virtual/JfrEvents.java failing intermittently

[sendaoYan]

Hi all,

This pull request contains a backport of commit 58e75815 from the openjdk/jdk repository. I add --enable-preview paramerer to @compile and @run junit since unnamed is preview feature in jdk21u. All other parts are backport cleanly.

The test is changed to use Thread::join so it waits for the 100 threads to terminate, avoid the fragile sleep.

Change has been verified locally on linux-x64. Test-fix only, no risk.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8365893 needs maintainer approval

Issue

• JDK-8365893: test/jdk/java/lang/Thread/virtual/JfrEvents.java failing intermittently (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2122/head:pull/2122
$ git checkout pull/2122

Update a local copy of the PR:
$ git checkout pull/2122
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2122

View PR using the GUI difftool:
$ git pr show -t 2122

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2122.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 05: Full - Incremental (218ba38a)
• 04: Full - Incremental (4f26d045)
• 03: Full - Incremental (81e3951f)
• 02: Full - Incremental (78452d8f)
• 01: Full - Incremental (c1471771)
• 00: Full (a22ba47b)

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Can not backport to jdk21u-dev directly.

/home/runner/work/jdk21u-dev/jdk21u-dev/test/jdk/java/lang/Thread/virtual/JfrEvents.java:78: error: unnamed variables are a preview feature and are disabled by default.
                        .mapToObj(_ -> Thread.startVirtualThread(() -> { }))
                                  ^
  (use --enable-preview to enable unnamed variables)