8358751: C2: Recursive inlining check for compiled lambda forms is broken

[wkia]

This is backport of JDK-8358751, as it's reported jdk21 is affected.

Clean backport. Tier1 is OK.

The reproducer crashes before the fix, and OK after the fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8358751 needs maintainer approval

Issue

• JDK-8358751: C2: Recursive inlining check for compiled lambda forms is broken (Bug - P2 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2294/head:pull/2294
$ git checkout pull/2294

Update a local copy of the PR:
$ git checkout pull/2294
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2294

View PR using the GUI difftool:
$ git pr show -t 2294

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2294.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (14d037bf)

[wkia]

/approval request I'd like to backport this to jdk21u-dev, as it's reported jdk21 is affected. Clean backport. Tier1 is OK. The reproducer crashes before the fix, and OK after the fix.

[openjdk]

@wkia
8358751: The approval request has been created successfully.

[GoeLin]

Please backport to 25 first. Removing label in meantime.

[GoeLin]

Hi @wkia
this fix is brand new and in a central component.
I would prefer to delay this to the next release of 21.
Do you know which change caused this issue?
Could you please link it to the JBS issue?
Thanks.

[wkia]

@GoeLin Probably it's caused by "8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods".
This issue is mentioned in JDK-8358751's comments, but I don't know why it's not linked.

[GoeLin]

Ah, 8011138 is not visible to the public, so we an not link it.
Let's wait for April, please.