Skip to content

Conversation

satyenme
Copy link

@satyenme satyenme commented Oct 15, 2025

Backporting JDK-8352678: Opensource few JMenuItem tests and JDK-8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java (caused by first JBS issue). Renames a test file, and open sources 4 tests. Ran GHA Sanity Checks and new tests directly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352678 needs maintainer approval
  • JDK-8357305 needs maintainer approval

Issues

  • JDK-8352678: Opensource few JMenuItem tests (Bug - P4)
  • JDK-8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2332/head:pull/2332
$ git checkout pull/2332

Update a local copy of the PR:
$ git checkout pull/2332
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2332/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2332

View PR using the GUI difftool:
$ git pr show -t 2332

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2332.diff

Using Webrev

Link to Webrev Comment

@satyenme
Copy link
Author

/issue add 8357305

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8a40498d79a18dcf91cf4979d34c3583a6c39322 8352678: Opensource few JMenuItem tests Oct 15, 2025
@openjdk
Copy link

openjdk bot commented Oct 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 15, 2025
@openjdk
Copy link

openjdk bot commented Oct 15, 2025

@satyenme
Adding additional issue to issue list: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java.

@mlbridge
Copy link

mlbridge bot commented Oct 15, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant