Skip to content

Conversation

cost0much
Copy link
Contributor

@cost0much cost0much commented Oct 16, 2025

Clean backport. Fixes ConstantOopReadValue::print_on printing 'nullptr' when it should print 'null'; this is a regression from JDK-8300242 introduced in 21-ga openjdk/jdk@cfe5746. GHA passes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323803 needs maintainer approval

Issue

  • JDK-8323803: ConstantOopReadValue::print_on should print 'null' instead of 'nullptr' (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2345/head:pull/2345
$ git checkout pull/2345

Update a local copy of the PR:
$ git checkout pull/2345
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2345

View PR using the GUI difftool:
$ git pr show -t 2345

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2345.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

@cost0much This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323803: ConstantOopReadValue::print_on should print 'null' instead of 'nullptr'

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 7620b129888d57514d9ef588e0681f1d43377236 8323803: ConstantOopReadValue::print_on should print 'null' instead of 'nullptr' Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 16, 2025
@cost0much cost0much marked this pull request as ready for review October 16, 2025 16:52
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2025
@cost0much
Copy link
Contributor Author

/approval request Fixes ConstantOopReadValue::print_on printing 'nullptr' when it should print 'null'; this is a regression introduced in 21-ga. Applies cleanly from JDK24 and no bugtail. Passes GHA. Medium-low risk as touches hotspot, but it only affects debug output and doesn't affect runtime in any way.

@mlbridge
Copy link

mlbridge bot commented Oct 16, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

@cost0much
8323803: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 16, 2025
@cost0much
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 17, 2025
@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@cost0much
Your change (at version b487d37) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored

Development

Successfully merging this pull request may close these issues.

1 participant