-
Notifications
You must be signed in to change notification settings - Fork 144
8323803: ConstantOopReadValue::print_on should print 'null' instead of 'nullptr' #2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
@cost0much This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Fixes ConstantOopReadValue::print_on printing 'nullptr' when it should print 'null'; this is a regression introduced in 21-ga. Applies cleanly from JDK24 and no bugtail. Passes GHA. Medium-low risk as touches hotspot, but it only affects debug output and doesn't affect runtime in any way. |
@cost0much |
/integrate |
@cost0much |
Clean backport. Fixes ConstantOopReadValue::print_on printing 'nullptr' when it should print 'null'; this is a regression from JDK-8300242 introduced in 21-ga openjdk/jdk@cfe5746. GHA passes.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2345/head:pull/2345
$ git checkout pull/2345
Update a local copy of the PR:
$ git checkout pull/2345
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2345/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2345
View PR using the GUI difftool:
$ git pr show -t 2345
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2345.diff
Using Webrev
Link to Webrev Comment