8370214: [21u] Remove -Xdebug and -Xnoagent from tests: backport parts of 8227229 and 8312072

[GoeLin]

This is a backport of the test parts of

8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6
and
8312072: Deprecate for removal the -Xnoagent option

I prepared two commits to separate the edits of each of these.

Backporting these changes makes
8327704: Update nsk/jdi tests to use driver instead of othervm
a clean backport. As 8327704 is huge, it would be quite unpleasant to review. See #2359

Removing the usage of the options in 21 is fine as the effect of these options has been removed before 21.
I do not and can not backport the deprecation part of the change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8370214 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370214: [21u] Remove -Xdebug and -Xnoagent from tests: backport parts of 8227229 and 8312072 (Bug - P4 - Requested)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2353/head:pull/2353
$ git checkout pull/2353

Update a local copy of the PR:
$ git checkout pull/2353
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2353

View PR using the GUI difftool:
$ git pr show -t 2353

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2353.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 00: Full (8a171f52)

[MBaesken]

Makes sense ; but in 21u-dev we have a few more places where those flags show up, e.g. netbeans-targets.xml . See https://github.com/search?q=repo%3Aopenjdk%2Fjdk21u-dev+%22-Xdebug%22&type=code
should those be kicked out too ?

[MBaesken]

Even in jdk (jdk26) we still mentioned '-Xdebug' in src/hotspot/share/prims/jvmti.xml ; should we better kick it out there (separate JBS issue) ?

[GoeLin]

Hi @MBaesken
well, the mentioning of the flag in the man pages should not be removed, as the situation is unchanged. I do not backport the removal of the flag. Fixing of at least a row of the places your query shows was in the original change.
In head though, I think any remains should be removed if possible.
Thanks for the review!

The netbeans occurance seems to be missed by the original change.

Probably I should also have omitted the changes to make/ide/netbeans/langtools/build.xml and src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.