Skip to content

Conversation

jcking
Copy link

@jcking jcking commented Oct 17, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369190 needs maintainer approval

Issue

  • JDK-8369190: JavaFrameAnchor on AArch64 has unnecessary barriers and wrong store order in MacroAssembler (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2356/head:pull/2356
$ git checkout pull/2356

Update a local copy of the PR:
$ git checkout pull/2356
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2356/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2356

View PR using the GUI difftool:
$ git pr show -t 2356

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2356.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2025

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fd29677479797956e0d205b5ce6e7cb9ad407bd1 8369190: JavaFrameAnchor on AArch64 has unnecessary barriers and wrong store order in MacroAssembler Oct 17, 2025
@openjdk
Copy link

openjdk bot commented Oct 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 17, 2025
@openjdk
Copy link

openjdk bot commented Oct 17, 2025

⚠️ @jcking This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2025
@jcking
Copy link
Author

jcking commented Oct 17, 2025

/approval request

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@jcking
8369190: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 17, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant