Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 19, 2026

I backport this for parity with 21.0.11-oracle

I had to redo this as other pushes touched the same file.
Now I also needed a trivial resolve.
Let's see whether it's still clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359388 needs maintainer approval

Integration blocker

 ⚠️ Dependency #2554 must be integrated first

Issue

  • JDK-8359388: Stricter checking for cipher transformations (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2555/head:pull/2555
$ git checkout pull/2555

Update a local copy of the PR:
$ git checkout pull/2555
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2555

View PR using the GUI difftool:
$ git pr show -t 2555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2555.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2026

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/2554 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 19, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport ec7c6be6a9e84c8cd2077fea07930592ddd13669 8359388: Stricter checking for cipher transformations Jan 19, 2026
@openjdk
Copy link

openjdk bot commented Jan 19, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jan 19, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2026

Webrevs

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Jan 21, 2026
@openjdk
Copy link

openjdk bot commented Jan 21, 2026

⚠️ @GoeLin This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@GoeLin GoeLin force-pushed the goetz_backport_8359388 branch from baddaa2 to 2ff59a2 Compare January 21, 2026 09:18
@openjdk
Copy link

openjdk bot commented Jan 21, 2026

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received labels Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant