-
Notifications
You must be signed in to change notification settings - Fork 151
8359388: Stricter checking for cipher transformations #2555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/2554
Are you sure you want to change the base?
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
|
baddaa2 to
2ff59a2
Compare
|
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
I backport this for parity with 21.0.11-oracle
I had to redo this as other pushes touched the same file.
Now I also needed a trivial resolve.
Let's see whether it's still clean.
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2555/head:pull/2555$ git checkout pull/2555Update a local copy of the PR:
$ git checkout pull/2555$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2555/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2555View PR using the GUI difftool:
$ git pr show -t 2555Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2555.diff
Using Webrev
Link to Webrev Comment