Skip to content

Conversation

@schmelter-sap
Copy link
Contributor

@schmelter-sap schmelter-sap commented Jan 23, 2026

Backport for parity with 21.0.11-oracle.

  • added missing doPrivileged() calls when accessing the two system properties used in SslRMIClientSocketFactory
  • adjusted additionally to change 8341496, which added another system property to check and was missing the doPrivileged() call too
  • added test

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8366866 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366866: SslRMIClientSocketFactory#createSocket lacking priviledges (securitymanger) (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2564/head:pull/2564
$ git checkout pull/2564

Update a local copy of the PR:
$ git checkout pull/2564
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2564

View PR using the GUI difftool:
$ git pr show -t 2564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2564.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2026

👋 Welcome back rschmelter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@schmelter-sap schmelter-sap reopened this Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 8366866 8366866: SslRMIClientSocketFactory#createSocket lacking priviledges (securitymanger) Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Jan 23, 2026
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant