Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 19, 2025

Hi all,

This pull request contains a backport of commit 360777c3 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 19 Dec 2025 and was reviewed by David Holmes and Andrew Haley.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8371948 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8371948: TestStackOverflowDuringInit.java fails xss too small on linux-aarch64 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/114/head:pull/114
$ git checkout pull/114

Update a local copy of the PR:
$ git checkout pull/114
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/114/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 114

View PR using the GUI difftool:
$ git pr show -t 114

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/114.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371948: TestStackOverflowDuringInit.java fails xss too small on linux-aarch64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 360777c3ad8fe5bfeb2af15ce1b89e04d4397b9f 8371948: TestStackOverflowDuringInit.java fails xss too small on linux-aarch64 Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug which cause test fails on some linux-aarch64 machines. Change has been verified locally on linux-x64 and linux-aarch64 by run the test test/hotspot/jtreg/runtime/ClassInitErrors/TestStackOverflowDuringInit.java manually.

@openjdk
Copy link

openjdk bot commented Dec 25, 2025

@sendaoYan
8371948: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 25, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.
/integrate

@openjdk
Copy link

openjdk bot commented Jan 1, 2026

Going to push as commit 5a26e1e.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 1, 2026
@openjdk openjdk bot closed this Jan 1, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 1, 2026
@openjdk
Copy link

openjdk bot commented Jan 1, 2026

@sendaoYan Pushed as commit 5a26e1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Waiting openjdk/jdk11u-dev#3105 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant