Skip to content

Conversation

shyamkishororacle
Copy link
Contributor

@shyamkishororacle shyamkishororacle commented Aug 20, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8361492 needs maintainer approval

Issue

  • JDK-8361492: [IR Framework] Has too restrictive regex for load and store (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/110/head:pull/110
$ git checkout pull/110

Update a local copy of the PR:
$ git checkout pull/110
$ git pull https://git.openjdk.org/jdk25u.git pull/110/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 110

View PR using the GUI difftool:
$ git pr show -t 110

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/110.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2025

👋 Welcome back shyamkishororacle! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ebb1095805579f8f32a81bb350198fa1b7add9eb 8361492: [IR Framework] Has too restrictive regex for load and store Aug 20, 2025
@openjdk
Copy link

openjdk bot commented Aug 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 20, 2025
@openjdk
Copy link

openjdk bot commented Aug 20, 2025

⚠️ @shyamkishororacle This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 20, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant