Skip to content

Conversation

shyamkishororacle
Copy link
Contributor

@shyamkishororacle shyamkishororacle commented Aug 20, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8361494 needs maintainer approval

Issue

  • JDK-8361494: [IR Framework] Escape too much in replacement of placeholder (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/113/head:pull/113
$ git checkout pull/113

Update a local copy of the PR:
$ git checkout pull/113
$ git pull https://git.openjdk.org/jdk25u.git pull/113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 113

View PR using the GUI difftool:
$ git pr show -t 113

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/113.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2025

👋 Welcome back shyamkishororacle! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

@shyamkishororacle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361494: [IR Framework] Escape too much in replacement of placeholder

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 76442f39b9dd583f09a7adebb0fc5f37b6ef88ef 8361494: [IR Framework] Escape too much in replacement of placeholder Aug 20, 2025
@openjdk
Copy link

openjdk bot commented Aug 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 20, 2025
@openjdk
Copy link

openjdk bot commented Aug 20, 2025

⚠️ @shyamkishororacle This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 20, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2025

Webrevs

@shyamkishororacle
Copy link
Contributor Author

/approval 8361494 request Clean backport. [IR Framework] Escape too much in replacement of placeholder

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@shyamkishororacle
8361494: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

⚠️ @shyamkishororacle the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8361494
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 25, 2025
@shyamkishororacle
Copy link
Contributor Author

/approval 8361494 request Clean backport. [IR Framework] Escape too much in replacement of placeholder

@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@shyamkishororacle
8361494: Approval has already been requested and approved.

@shyamkishororacle
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 26, 2025
@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@shyamkishororacle
Your change (at version 14d5eae) is now ready to be sponsored by a Committer.

@shyamkishororacle
Copy link
Contributor Author

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@shyamkishororacle Only Committers are allowed to sponsor changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

1 participant