Skip to content

Conversation

abhn-git
Copy link
Contributor

@abhn-git abhn-git commented Aug 20, 2025

jdk-25.0.1/bin/java -jar jtreg7.5.2/jtreg/lib/jtreg.jar -testjdk:jdk-25.0.1 -verbose:summary -dir:jdk25u-cpu/open/test/langtools tools/javac/launcher/SourceLauncherStackTraceTest.java tools/javac/launcher/SourceLauncherTest.java
Passed: tools/javac/launcher/SourceLauncherStackTraceTest.java
Passed: tools/javac/launcher/SourceLauncherTest.java
Test results: passed: 2
Report written to C:\jck\colocation\JTreport\html\report.html
Results written to C:\jck\colocation\JTwork


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8364545 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8364545: tools/javac/launcher/SourceLauncherTest.java fails frequently (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/115/head:pull/115
$ git checkout pull/115

Update a local copy of the PR:
$ git checkout pull/115
$ git pull https://git.openjdk.org/jdk25u.git pull/115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 115

View PR using the GUI difftool:
$ git pr show -t 115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/115.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2025

👋 Welcome back abhn-git! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 1a206d2a6cade07249f6922072ac9d29aa56bc43 8364545: tools/javac/launcher/SourceLauncherTest.java fails frequently Aug 20, 2025
@openjdk
Copy link

openjdk bot commented Aug 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 20, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2025

Webrevs

@abhn-git
Copy link
Contributor Author

/approval

@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@abhn-git usage: /approval [<id>] (request|cancel) [<text>]

@abhn-git
Copy link
Contributor Author

/approval 8364545 request backporting changes to 25u

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

@abhn-git
8364545: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 27, 2025
@liach
Copy link
Member

liach commented Aug 27, 2025

Hmm, 25u has no https://bugs.openjdk.org/browse/JDK-8362237, so if this works in a backport it probably indicates this test is a failure.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Aug 29, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2025

@abhn-git This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants