Skip to content

8362889: [GCC static analyzer] leak in libstringPlatformChars.c #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −6
Open

8362889: [GCC static analyzer] leak in libstringPlatformChars.c #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions test/jdk/java/lang/String/nativeEncoding/libstringPlatformChars.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -58,19 +58,23 @@ Java_StringPlatformChars_newString(JNIEnv *env, jclass unused, jbyteArray bytes)
char* str;
int len = (*env)->GetArrayLength(env, bytes);
int i;
jbyte* jbytes;

str = (char*)malloc(len + 1);
jbytes = (*env)->GetPrimitiveArrayCritical(env, bytes, NULL);
jbyte* jbytes = (*env)->GetPrimitiveArrayCritical(env, bytes, NULL);
if (jbytes == NULL) {
return NULL;
}
str = (char*)malloc(len + 1);
if (str == NULL) {
(*env)->ReleasePrimitiveArrayCritical(env, bytes, (void*)jbytes, 0);
return NULL;
}
for (i = 0; i < len; i++) {
str[i] = (char)jbytes[i];
}
str[len] = '\0';
(*env)->ReleasePrimitiveArrayCritical(env, bytes, (void*)jbytes, 0);

return JNU_NewStringPlatform(env, str);
jstring res = JNU_NewStringPlatform(env, str);
free(str);
return res;
}