Skip to content

Conversation

xiezhaokun
Copy link
Member

@xiezhaokun xiezhaokun commented Aug 28, 2025

Hi all,

This pull request contains a backport of commit dccb1782 from the openjdk/jdk repository.

The commit being backported was authored by Yadong Wang on 22 Jul 2025 and was reviewed by Aleksey Shipilev and Andrew Dinn.

Thanks!


Progress

  • JDK-8361892 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361892: AArch64: Incorrect matching rule leading to improper oop instruction encoding (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/140/head:pull/140
$ git checkout pull/140

Update a local copy of the PR:
$ git checkout pull/140
$ git pull https://git.openjdk.org/jdk25u.git pull/140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 140

View PR using the GUI difftool:
$ git pr show -t 140

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/140.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2025

👋 Welcome back zxie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

@xiezhaokun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361892: AArch64: Incorrect matching rule leading to improper oop instruction encoding

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5e07074: 8361112: Use exact float -> Float16 conversion method in Float16 tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport dccb1782ec35d1ee95220a237aef29ddfc292cbd 8361892: AArch64: Incorrect matching rule leading to improper oop instruction encoding Aug 28, 2025
@openjdk
Copy link

openjdk bot commented Aug 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 28, 2025
@openjdk
Copy link

openjdk bot commented Aug 28, 2025

⚠️ @xiezhaokun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 28, 2025
@xiezhaokun
Copy link
Member Author

/approval request The same issue was reproduced on jdk25u. The crash is resolved with this fix.

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

@xiezhaokun
8361892: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 28, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 28, 2025

Webrevs

@xiezhaokun
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

@xiezhaokun This pull request has not yet been marked as ready for integration.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 29, 2025
@shipilev
Copy link
Member

shipilev commented Sep 1, 2025

For JDK updates, you need to secure an approval. Now it is granted, so PR is integrateable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants