Skip to content

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented Aug 28, 2025

Hi all,

This pull request contains a backport of commit 501e6aed from the openjdk/jdk repository.

The commit being backported was authored by Axel Boldt-Christmas on 28 Aug 2025 and was reviewed by Stefan Karlsson and Joel Sikström.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366223 needs maintainer approval

Issue

  • JDK-8366223: ZGC: ZPageAllocator::cleanup_failed_commit_multi_partition is broken (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.org/jdk25u.git pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/141.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2025

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

@xmas92 This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot changed the title Backport 501e6aed4407d63b000320168dc5d0553ce8a23b 8366223: ZGC: ZPageAllocator::cleanup_failed_commit_multi_partition is broken Aug 28, 2025
@openjdk
Copy link

openjdk bot commented Aug 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 28, 2025
@openjdk
Copy link

openjdk bot commented Aug 28, 2025

⚠️ @xmas92 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 28, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 28, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 28, 2025
@xmas92 xmas92 force-pushed the JDK-8366223-backport-jdk25u branch from c1e2fc6 to 75e46aa Compare September 1, 2025 08:45
@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@xmas92 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot removed clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Sep 1, 2025
@xmas92
Copy link
Member Author

xmas92 commented Sep 1, 2025

Included the https://bugs.openjdk.org/browse/JDK-8366462 one-line change.

Reason:
While we only saw problems with the normal case introduced with https://bugs.openjdk.org/browse/JDK-8366147, it may theoretically still happen with the ZFakeNUMA case. So to reduce potential test noise.

@xmas92 xmas92 requested a review from stefank September 1, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants