8361497: Scoped Values: orElse and orElseThrow do not access the cache

[rgithubli]

Backport of https://bugs.openjdk.org/browse/JDK-8361497

Not clean due to the lack of https://bugs.openjdk.org/browse/JDK-8360884. The cherry pick conflict was caused by the a new test added in the JDK-8360884., code. Based on the conversation in JDK-8360884, it seems people are not comfortable to backport JDK-8360884 into 25 yet. The conflict was easy to resolve tho. Just remove the additional test brought by JDK-8360884.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8361497 needs maintainer approval

Issue

• JDK-8361497: Scoped Values: orElse and orElseThrow do not access the cache (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/142/head:pull/142
$ git checkout pull/142

Update a local copy of the PR:
$ git checkout pull/142
$ git pull https://git.openjdk.org/jdk25u.git pull/142/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 142

View PR using the GUI difftool:
$ git pr show -t 142

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/142.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgithubli This change is no longer ready for integration - check the PR body for details.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rgithubli This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (522b9d5c)

[rgithubli]

/approval request for backport of JDK-8361497: Scoped Values: orElse and orElseThrow do not access the cache

Motivation: The current cache in ScopedValue does not update if it's a miss in the cache initially but the binding was found. This behavior slows down the performance of ScopedValue.orElse and ScopedValue.orElseThrow.

Risk: Relatively low. The change is in the tip for over a month. The same time, I do understand we want to make 25 as stable as possible after GA and this patch probably isn't too urgent. If this isn't good for 25u for now, let me know if it's good for 25u-dev once it's available.

[openjdk]

@rgithubli
8361497: The approval request has been created successfully.