Skip to content

8362532: Test gc/g1/plab/* duplicate command-line options #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −9
Open

8362532: Test gc/g1/plab/* duplicate command-line options #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/hotspot/jtreg/gc/g1/plab/TestPLABEvacuationFailure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ private static void runTest(int wastePct, int plabSize, int parGCThreads, int he
// Set up test GC and PLAB options
List<String> testOptions = new ArrayList<>();
Collections.addAll(testOptions, COMMON_OPTIONS);
Collections.addAll(testOptions, Utils.getTestJavaOpts());
Collections.addAll(testOptions,
"-XX:ParallelGCThreads=" + parGCThreads,
"-XX:ParallelGCBufferWastePct=" + wastePct,
Expand Down
14 changes: 6 additions & 8 deletions test/hotspot/jtreg/gc/g1/plab/lib/PLABUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,12 @@ public static List<String> prepareOptions(List<String> options) {
if (options == null) {
throw new IllegalArgumentException("Options cannot be null");
}
List<String> executionOtions = new ArrayList<>(
Arrays.asList(Utils.getTestJavaOpts())
);
Collections.addAll(executionOtions, WB_DIAGNOSTIC_OPTIONS);
Collections.addAll(executionOtions, G1_PLAB_LOGGING_OPTIONS);
Collections.addAll(executionOtions, GC_TUNE_OPTIONS);
executionOtions.addAll(options);
return executionOtions;
List<String> executionOptions = new ArrayList<>();
Collections.addAll(executionOptions, WB_DIAGNOSTIC_OPTIONS);
Collections.addAll(executionOptions, G1_PLAB_LOGGING_OPTIONS);
Collections.addAll(executionOptions, GC_TUNE_OPTIONS);
executionOptions.addAll(options);
return executionOptions;
}

/**
Expand Down