Skip to content

Conversation

shyamkishororacle
Copy link
Contributor

@shyamkishororacle shyamkishororacle commented Sep 3, 2025

…support for non-local debuggees


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359958 needs maintainer approval

Issue

  • JDK-8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/163/head:pull/163
$ git checkout pull/163

Update a local copy of the PR:
$ git checkout pull/163
$ git pull https://git.openjdk.org/jdk25u.git pull/163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 163

View PR using the GUI difftool:
$ git pr show -t 163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/163.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2025

👋 Welcome back shyamkishororacle! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 3, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 3, 2025

Webrevs

@shyamkishororacle shyamkishororacle changed the title 8359958: Cleanup local debuggee references after JDK-8333117 removed … Backport 39c9de2acea0537335230b1d1db606d90348bdb6 Sep 3, 2025
@openjdk openjdk bot changed the title Backport 39c9de2acea0537335230b1d1db606d90348bdb6 8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees Sep 3, 2025
@openjdk
Copy link

openjdk bot commented Sep 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Sep 3, 2025
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Launcher.java, looks like 97 was changed in the original commit, but not in the PR.

In DebugeeProcess.java, the original commit removed lines 41-45, but they are still in the PR.

Otherwise, looks clean.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2025

@shyamkishororacle This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants