Skip to content

Conversation

missa-prime
Copy link

@missa-prime missa-prime commented Oct 1, 2025

Hi all,

This pull request contains a backport of commit ef4cbec6 from the openjdk/jdk repository.

The commit being backported was authored by Mohamed Issa on 11 Jun 2025 and was reviewed by Sandhya Viswanathan and Vladimir Kozlov.

Thanks!


Progress

  • JDK-8358556 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358556: Assert when running with -XX:-UseLibmIntrinsic (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/260/head:pull/260
$ git checkout pull/260

Update a local copy of the PR:
$ git checkout pull/260
$ git pull https://git.openjdk.org/jdk25u.git pull/260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 260

View PR using the GUI difftool:
$ git pr show -t 260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/260.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2025

👋 Welcome back missa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@missa-prime This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358556: Assert when running with -XX:-UseLibmIntrinsic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 1c9880b: 8359104: gc/TestAlwaysPreTouchBehavior.java# fails on Linux
  • 61a014e: 8325766: Extend CertificateBuilder to create trust and end entity certificates programmatically
  • 7c60413: 8368367: Test jdk/jfr/event/gc/detailed/TestGCHeapMemoryUsageEvent.java fails jdk.GCHeapMemoryUsage "expected 0 > 0"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ef4cbec6fba77fd84b328d333f8592c6eedf1a2d 8358556: Assert when running with -XX:-UseLibmIntrinsic Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Oct 1, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 6, 2025
@vamsi-parasa
Copy link

/integrate

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@vamsi-parasa Only the author (@missa-prime) is allowed to issue the integrate command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants