Skip to content

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Aug 18, 2025

Clean backport. This is a performance improvement for the generational mode of Shenandoah.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359947 needs maintainer approval

Issue

  • JDK-8359947: GenShen: use smaller TLABs by default (Task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/99/head:pull/99
$ git checkout pull/99

Update a local copy of the PR:
$ git checkout pull/99
$ git pull https://git.openjdk.org/jdk25u.git pull/99/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 99

View PR using the GUI difftool:
$ git pr show -t 99

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/99.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 18, 2025

@earthling-amzn This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot changed the title Backport a0c3efa6a80fe95e22faf5a732e42f1e1291fb4c 8359947: GenShen: use smaller TLABs by default Aug 18, 2025
@openjdk
Copy link

openjdk bot commented Aug 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 18, 2025
@openjdk
Copy link

openjdk bot commented Aug 18, 2025

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 18, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2025

Webrevs

@earthling-amzn
Copy link
Author

/approval request This change addresses a performance issue which may cause Shenandoah to allocate LABs which are too large and may leave excess memory unused. We have tested this with GHA and additional jtreg and other performance and stress test suites.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@earthling-amzn
8359947: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 19, 2025
@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@earthling-amzn
Your change (at version ffa56c4) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

On further thought and reading through the set of mainline experiments, I suspect we should really do this after the CAS allocation path is done? This would mitigate any problems with contention on heap lock with smaller TLABs.

(The synopsis is also misleading, since it also affects non-generational Shenandoah -- but there is nothing to be done at this point.)

@earthling-amzn earthling-amzn marked this pull request as draft August 26, 2025 15:57
@openjdk openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required
Development

Successfully merging this pull request may close these issues.

2 participants