-
Notifications
You must be signed in to change notification settings - Fork 40
8359947: GenShen: use smaller TLABs by default #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8359947: GenShen: use smaller TLABs by default #99
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
@earthling-amzn This change is no longer ready for integration - check the PR body for details. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request This change addresses a performance issue which may cause Shenandoah to allocate LABs which are too large and may leave excess memory unused. We have tested this with GHA and additional jtreg and other performance and stress test suites. |
@earthling-amzn |
/integrate |
@earthling-amzn |
On further thought and reading through the set of mainline experiments, I suspect we should really do this after the CAS allocation path is done? This would mitigate any problems with contention on heap lock with smaller TLABs. (The synopsis is also misleading, since it also affects non-generational Shenandoah -- but there is nothing to be done at this point.) |
Clean backport. This is a performance improvement for the generational mode of Shenandoah.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/99/head:pull/99
$ git checkout pull/99
Update a local copy of the PR:
$ git checkout pull/99
$ git pull https://git.openjdk.org/jdk25u.git pull/99/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 99
View PR using the GUI difftool:
$ git pr show -t 99
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/99.diff
Using Webrev
Link to Webrev Comment