Skip to content

8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer #668

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a207869
8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer
Jul 15, 2025
a132e0c
Remove guarantee and add debug only warning, then return early when "…
Jul 17, 2025
55e4fe2
fix bugs
Jul 17, 2025
811ce78
Should be _cur >= BUFFER_LEN
Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions hotspot/src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -34,13 +34,14 @@
class LineBuffer: public StackObj {

private:
static const int BUFFER_LEN = 1024;
static const int BUFFER_LEN = 1024*3;
static const int INDENT_CHARS = 3;
char _buffer[BUFFER_LEN];
int _indent_level;
int _cur;

void vappend(const char* format, va_list ap) ATTRIBUTE_PRINTF(2, 0) {
guarantee(_cur < BUFFER_LEN, "buffer overflow in LineBuffer");
int res = os::vsnprintf(&_buffer[_cur], BUFFER_LEN - _cur, format, ap);
if (res > BUFFER_LEN) {
DEBUG_ONLY(warning("buffer too small in LineBuffer");)
Expand Down