-
Notifications
You must be signed in to change notification settings - Fork 169
8297088: Update LCMS to 2.14 #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch itself looks ok. Could you re-run the Windows x86_64 build? It seems to be failing in an odd way (failing to build FreeType) that I can't see is related to the change.
@gnu-andrew, thanks for the review. All builds have passed successfully after the merge, and the remaining test failures don't seem to be related to the backport:
|
I'd like to backport it for parity with Oracle 8u.
11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md.
I also fixed the file paths in UPDATING.txt instructions so that they match the paths in OpenJDK8.
GHA testing revealed no regressions, additionally tested manually with J2Ddemo.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/677/head:pull/677
$ git checkout pull/677
Update a local copy of the PR:
$ git checkout pull/677
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/677/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 677
View PR using the GUI difftool:
$ git pr show -t 677
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/677.diff
Using Webrev
Link to Webrev Comment