Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 29, 2025

Hi all,

Test tools/launcher/VersionCheck.java fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'. This failure fixed by JDK-8237192 in jdk15, only a subset of JDK-8237192 to fix this test failure. So it's not suitable to backport JDK-8237192 to jdk8u-dev, then I create this PR to fix this testbug.

This PR skip all the *.debuginfo files to check the '-version' or '-J-version'. Change has been verified localy, test-fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8353657 needs maintainer approval

Issue

  • JDK-8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/685/head:pull/685
$ git checkout pull/685

Update a local copy of the PR:
$ git checkout pull/685
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/685/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 685

View PR using the GUI difftool:
$ git pr show -t 685

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/685.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 29, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 29, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant