8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build #685
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Test tools/launcher/VersionCheck.java fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'. This failure fixed by JDK-8237192 in jdk15, only a subset of JDK-8237192 to fix this test failure. So it's not suitable to backport JDK-8237192 to jdk8u-dev, then I create this PR to fix this testbug.
This PR skip all the
*.debuginfo
files to check the '-version' or '-J-version'. Change has been verified localy, test-fix only, no risk.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/685/head:pull/685
$ git checkout pull/685
Update a local copy of the PR:
$ git checkout pull/685
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/685/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 685
View PR using the GUI difftool:
$ git pr show -t 685
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/685.diff
Using Webrev
Link to Webrev Comment