-
Notifications
You must be signed in to change notification settings - Fork 172
8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
Thanks for the reviews @phohensee /approval request Backport to partial fix the test bug, and will make the later backport JDK-8343340 to jdk8u cleanly. Change has been verifiedlocally on linux-x64 which swapping memory is enable. Test-fix only, no risk. |
|
@sendaoYan |
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/approval request Backport to partial fix the test bug, and will make the later backport JDK-8343340 to jdk8u cleanly. Change has been verifiedlocally on linux-x64 which swapping memory is enable. Test-fix only, no risk. |
|
@sendaoYan |
Hi all,
This backport PR partial fix the test bug, which may cause test fails without swapping memory. Change has been verified locally. Test-fix only, no risk. This backport will make later backport JDK-8343340 cleanly.
Only the different copyright year cause this backport uncleanly. Other parts are backport cleanly.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/708/head:pull/708$ git checkout pull/708Update a local copy of the PR:
$ git checkout pull/708$ git pull https://git.openjdk.org/jdk8u-dev.git pull/708/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 708View PR using the GUI difftool:
$ git pr show -t 708Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/708.diff
Using Webrev
Link to Webrev Comment