8211804: Constant AO_UNUSED_MBZ uses left shift of negative value

[zzambers]

Backport fixes left shift on negative value which is undefined behavior. This is required to build on newer clang (macos). See also backport of JDK-8157758.

File has different path on JDK 8, but changes applied cleanly.

Testing:
GHA: OK (failures seem unrelated)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8211804 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8211804: Constant AO_UNUSED_MBZ uses left shift of negative value (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/722/head:pull/722
$ git checkout pull/722

Update a local copy of the PR:
$ git checkout pull/722
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/722/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 722

View PR using the GUI difftool:
$ git pr show -t 722

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/722.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211804: Constant AO_UNUSED_MBZ uses left shift of negative value

Use unsigned shift.

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[mlbridge]

Webrevs

• 00: Full (1811e33d)

[openjdk]

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jerboaa]

LGTM

[zzambers]

/approval request Fix of undefined behavior causing warning/error on clang, trivial fix - low risk, GHA ok

[openjdk]

@zzambers
8211804: Can not be found in the JDK project.

[jerboaa]

@zzambers 8211804: Can not be found in the JDK project.

@kevinrushforth Any ideas what's going on? --^

[kevinrushforth]

@zzambers 8211804: Can not be found in the JDK project.

@kevinrushforth Any ideas what's going on? --^

It seems to be some intermittent issue with JBS. Retry it and see if that helps.

@erikj79 Should Skara retry automatically? It doesn't seem like it is in either this case or similar cases.

[jerboaa]

@zzambers 8211804: Can not be found in the JDK project.

@kevinrushforth Any ideas what's going on? --^

It seems to be some intermittent issue with JBS. Retry it and see if that helps.

It seems to be happening a lot today.

[zzambers]

/approval request Fix of undefined behavior causing warning/error on clang, trivial fix - low risk, GHA ok

[openjdk]

@zzambers
8211804: Can not be found in the JDK project.

[zzambers]

weird, It says it cannot find 8211804, but PR seems to be paired with jira
I have created fix request manually

[jerboaa]

/approve yes

(also checking if the JBS issues remain)

[openjdk]

@jerboaa
8211804: The approval request has been approved.

[zzambers]

/integrate

[openjdk]

Going to push as commit f67be21.

[openjdk]

@zzambers Pushed as commit f67be21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.