Skip to content

Conversation

@TheMangovnik
Copy link

@TheMangovnik TheMangovnik commented Dec 2, 2025

Backport of JDK-8341964 - Add mechanism to disable different parts of TLS cipher suite

Preparation for backport of JDK-8245545 to comply with Oracle JRE and JDK Cryptographic Roadmap

Tested in RHEL9 VM:

  • Not clean backport.
  • Passed T1 tests.
  • jdk_security tests -> 4 fails. Same fails before and after backport. They are unrelated. Probably some incorrect set up in my VM. The failing tests:
    • sun/security/pkcs11/KeyStore/SecretKeysBasic.sh
    • sun/security/pkcs11/Provider/Login.sh
    • sun/security/pkcs11/Signature/TestDSAKeyLength.java
    • sun/security/tools/keytool/autotest.sh
  • GHA -> Linux x86/x64 hotspot/tier1 failing, seems unrelated to this backport, same fails in other already closed and integrated PRs

Extra changes:

  • in jdk/test/sun/security/ssl/CipherSuite/TLSCipherSuiteWildCardMatchingDisablePartsOfCipherSuite.java on line 58 changed List.of() to Array.asList() (and added import for it) because the former is not supported by jdk8.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8343623 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8341964 needs maintainer approval

Issues

  • JDK-8341964: Add mechanism to disable different parts of TLS cipher suite (Enhancement - P3)
  • JDK-8343623: Add mechanism to disable different parts of TLS cipher suite (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/730/head:pull/730
$ git checkout pull/730

Update a local copy of the PR:
$ git checkout pull/730
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/730/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 730

View PR using the GUI difftool:
$ git pr show -t 730

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/730.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2025

👋 Welcome back TheMangovnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 37f8029d4e64937e648784466acf9383d522543e 8341964: Add mechanism to disable different parts of TLS cipher suite Dec 2, 2025
@openjdk
Copy link

openjdk bot commented Dec 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 2, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant