-
Notifications
You must be signed in to change notification settings - Fork 5
8369140: GHA: Update macOS / x64 build to use macos-15-intel runner #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8369140: GHA: Update macOS / x64 build to use macos-15-intel runner #23
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request GHA-only fix for macOS x64 testing. Needed to avoid the case where GHA builds stop working in a month or so. |
@kevinrushforth |
@johanvos Can you approve this PR when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that this is documented. It should be clear that we use GhA for some testing, but we don't use it for doing production builds because we don't control the version of the tools (e.g. xcode 15.4 on macOs 15)
/approve yes |
@johanvos |
/integrate |
@kevinrushforth Pushed as commit 05d3a21. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of GHA fix to jfx25u.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx25u.git pull/23/head:pull/23
$ git checkout pull/23
Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.org/jfx25u.git pull/23/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23
View PR using the GUI difftool:
$ git pr show -t 23
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx25u/pull/23.diff
Using Webrev
Link to Webrev Comment