8427: Text getting overlapped on graph of Processes screen

[aymane-harmaz]

When the width of the chart title label exceeds the left margin ( xOffset) reserved for it, the label is truncated without taking into account the width of the y-axis tick labels. This can potentially lead to overlapping between the chart title and the y-axis tick labels.

Currently, the width of the y-axis tick labels is determined at the formatter level and is not dynamically available during chart label truncation.

Two potential workarounds are :

• Increase the xOffset size for the affected chart, allocating enough space to display both the chart title and the tick labels without overlap.
  (This impacts only the chart in question.)
• Base Chart title label truncation on a default value for y-axis tick labels, even without access to exact tick widths.
  (This impacts all charts.)

I followed the first strategy.

Screenshot of processes page post change :

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8427: Text getting overlapped on graph of Processes screen (Bug - P3)

Reviewers

• Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/678/head:pull/678
$ git checkout pull/678

Update a local copy of the PR:
$ git checkout pull/678
$ git pull https://git.openjdk.org/jmc.git pull/678/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 678

View PR using the GUI difftool:
$ git pr show -t 678

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/678.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aymane-harmaz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8427: Text getting overlapped on graph of Processes screen

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 3922e8a: 8425: Problem importing in Eclipse due to missing awatility 3rd party artifact
• 2bb16fa: 8365: Jolokia - Additional support for security mechanisms related to SSL / authentication, discovery restrictions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (e6e197d2)

[thegreystone]

I'll approve. It would be nice in the future to be able to avoid magic numbers, but this at least leaves us in a better place.

[aymane-harmaz]

/integrate

[openjdk]

@aymane-harmaz
Your change (at version e6e197d) is now ready to be sponsored by a Committer.

[bridgekeeper]

@aymane-harmaz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[aymane-harmaz]

/keepalive

[openjdk]

@aymane-harmaz The pull request is being re-evaluated and the inactivity timeout has been reset.