Skip to content

8451: Should make the Event Type the first column of event types tree table #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8451: Should make the Event Type the first column of event types tree table #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...htrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,11 @@ public Color getColor(IItem item) {

// FIXME: Handle ColorProvider and combined events
Map<String, Integer> columnsOrderMap = new HashMap<>();
columnsOrderMap.put(createColumnId(JfrAttributes.START_TIME), 1);
columnsOrderMap.put(createColumnId(JfrAttributes.DURATION), 2);
columnsOrderMap.put(createColumnId(JfrAttributes.END_TIME), 3);
columnsOrderMap.put(createColumnId(JfrAttributes.EVENT_THREAD), 4);
columnsOrderMap.put(createColumnId(JfrAttributes.EVENT_TYPE), 1);
columnsOrderMap.put(createColumnId(JfrAttributes.START_TIME), 2);
columnsOrderMap.put(createColumnId(JfrAttributes.DURATION), 3);
columnsOrderMap.put(createColumnId(JfrAttributes.END_TIME), 4);
columnsOrderMap.put(createColumnId(JfrAttributes.EVENT_THREAD), 5);
DEFAULT_COLUMNS_ORDER = Collections.unmodifiableMap(columnsOrderMap);
}

Expand Down
1 change: 0 additions & 1 deletion ...htrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/EventBrowserPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ private void rebuildItemList() {
}

// FIXME: Possibly move to attribute toolkit/handler?
// FIXME: Make sure to get Event Type as the first column
// FIXME: Stream<IType> -> Stream<IAttribute> should be delegated to some context (e.g. the editor)
Stream<IAttribute<?>> commonAttributes = Stream.empty();
if (types.hasNext()) {
Expand Down