Skip to content

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Jan 29, 2026

Please review this change that adds support for running JEP 512: Compact Source Files and Instance Main Methods as jtreg main tests.

This pull request also adds JDK 25 to the GHA-based CI workflow and updates to use newer GitHub actions: actions/checkout@v6 and actions/setup-java@v5


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • CODETOOLS-7904141: JTReg should support running compact source files (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/313/head:pull/313
$ git checkout pull/313

Update a local copy of the PR:
$ git checkout pull/313
$ git pull https://git.openjdk.org/jtreg.git pull/313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 313

View PR using the GUI difftool:
$ git pr show -t 313

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/313.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2026

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 29, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@sormuras sormuras marked this pull request as ready for review January 29, 2026 14:54
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 29, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants