-
Notifications
You must be signed in to change notification settings - Fork 120
8355227: [lworld] Clarify preview API status for some valhalla APIs #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lworld
Are you sure you want to change the base?
Conversation
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@liach This pull request is now open |
Per JEP 12:
According to these rules, the
Objects
methods and theIdentityException
class themselves must be reflective preview APIs: programs compiled without preview feature dependencies that are running with preview features enabled should be able to access these APIs, as at run-time, they may receive value objects andIdentityException
thrown by the JVM.The only remaining essential preview APIs are the constructors of
IdentityException
: non-preview programs have no reason to construct them.In addition, fixed a few JEP feature reference: notably, add reference to Strict Fields JEP.
Also, made ClassFile API new models reflective preview APIs - class file processors wish to process structures from preview class files even if the current runtime is not in preview. This is already happening to javac and javap.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1439/head:pull/1439
$ git checkout pull/1439
Update a local copy of the PR:
$ git checkout pull/1439
$ git pull https://git.openjdk.org/valhalla.git pull/1439/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1439
View PR using the GUI difftool:
$ git pr show -t 1439
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1439.diff
Using Webrev
Link to Webrev Comment