8359370: [lworld] allow instance fields of identity classes to be readable in the prologue phase #1490
Conversation
|
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
|
@vicente-romero-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 147 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Just curious, why is field proxies so late in the stages? Is it because strict fields cannot be used by lowered structures, etc.? |
| y = Inner1.this.x; // FAIL - early 'this' reference | ||
| super(); | ||
| } | ||
|
|
||
| public class Inner1a extends Inner1 { |
There was a problem hiding this comment.
moved the code above to new file EarlyAssignments2.java as now if fails in Flow not in Resolve, so it was not being reported by javac
| this.x++; // this should FAIL | ||
| super(); | ||
| } | ||
|
|
||
| public SuperInitFails(float[] x) { |
There was a problem hiding this comment.
moved to EarlyAssignments2, too
sorry I missed your question, well what this phase is doing is kind of similar to what we do in Lower, actually I don't discard folding the code into lower in the future, this is probably one of the reasons it is so close to Lower. We certainly need it after Flow |
|
|
openjdk
bot
added
ready
Webrevs
|
|
@vicente-romero-oracle This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
openjdk
bot
added
ready
|
@vicente-romero-oracle This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Before this fix only strict fields were readable in the prologue phase. The proposed fix should allow any instance fields of identity classes to be readable in the prologue phase. This implies changes in flow analysis as before we were only tracking final and strict fields. There is also some "cooperation" needed in the code to detect cases when reading a field is not allowed in the prologue phase. For example some methods in Resolve don't have all the needed information at the moment they are dealing with some ASTs and part of the processing needs to be done in Attr
TIA
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1490/head:pull/1490$ git checkout pull/1490Update a local copy of the PR:
$ git checkout pull/1490$ git pull https://git.openjdk.org/valhalla.git pull/1490/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1490View PR using the GUI difftool:
$ git pr show -t 1490Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1490.diff
Using Webrev
Link to Webrev Comment