8359370: [lworld] allow instance fields of identity classes to be readable in the prologue phase #1523
Conversation
|
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
|
@vicente-romero-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 120 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| ListBuffer<JCTree> prologueCode = new ListBuffer<>(); | ||
| for (JCTree stat : tree.body.stats) { | ||
| prologueCode.add(stat); | ||
| // gather all the stats in the body until a `super` or `this` invocation is found |
There was a problem hiding this comment.
I think this comment should explain that super/this invocation is included because its arguments are restricted too.
| @@ -18,7 +18,7 @@ class InnerSuperclass { } | |||
| static class InnerOuter extends EarlyIndirectOuterCapture { // accessible | |||
| class InnerInnerOuter extends EarlyIndirectOuterCapture { // not accessible | |||
| InnerInnerOuter() { | |||
| super(/* which enclosing instance here ? */new InnerSuperclass() { }); | |||
| super(new InnerSuperclass() { }); // should this be accepted?, InnerSuperclass is not an inner class of InnerInnerOuter | |||
There was a problem hiding this comment.
Probably yes, I think our agreement last time is that local/anonymous classes' captures, including the "outer this", are synthetic.
| @@ -2,7 +2,7 @@ | |||
| * @test /nodynamiccopyright/ | |||
| * @bug 8334258 | |||
| * @summary Disallow early assignment if FLEXIBLE_CONSTRUCTORS preview feature is not enabled | |||
| * @compile/fail/ref=EarlyAssignmentNoPreview1.out -XDrawDiagnostics EarlyAssignmentNoPreview1.java | |||
| * @compile/fail/ref=EarlyAssignmentNoPreview1.out --release 24 -XDrawDiagnostics EarlyAssignmentNoPreview1.java | |||
There was a problem hiding this comment.
this test along with EarlyAssigmentNoPreview 2 and 3 are failing. But the idea is to integrate this PR after the code for flexible constructor bodies have been merged into lworld, which should make these 3 tests pass
openjdk
bot
added
ready
Before this fix only strict fields were readable in the prologue phase. The proposed fix should allow any instance fields of identity classes to be readable in the prologue phase. This implies changes in flow analysis as before we were only tracking final and strict fields. There is also some "cooperation" needed in the code to detect cases when reading a field is not allowed in the prologue phase. For example some methods in Resolve don't have all the needed information at the moment they are dealing with some ASTs and part of the processing needs to be done in Attr
TIA
This PR is a remake of #1490
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1523/head:pull/1523$ git checkout pull/1523Update a local copy of the PR:
$ git checkout pull/1523$ git pull https://git.openjdk.org/valhalla.git pull/1523/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1523View PR using the GUI difftool:
$ git pr show -t 1523Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1523.diff
Using Webrev
Link to Webrev Comment