Skip to content

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Oct 3, 2025

When running with JTREG_REPEAT_COUNT=1000 I get the same error as skynet in JDK-8342977, so I'm using that number for the ProblemList-Virtual.txt. This fails intermittently without JTREG_TEST_THREAD_FACTORY=Virtual, so maybe this belongs in ProblemList.txt instead, as well as Skynet.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8314996: [lworld] java/lang/Thread/virtual/stress/PingPong.java fails since jdk-22+8 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1657/head:pull/1657
$ git checkout pull/1657

Update a local copy of the PR:
$ git checkout pull/1657
$ git pull https://git.openjdk.org/valhalla.git pull/1657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1657

View PR using the GUI difftool:
$ git pr show -t 1657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1657.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2025

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314996: [lworld] java/lang/Thread/virtual/stress/PingPong.java fails since jdk-22+8

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 184 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant