8368795: [lworld] javac rejects assignments to components of array fields with initializers in the prologue #1664
+28
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds with initializers in the prologue
|
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
liach
reviewed
Oct 6, 2025
|
|
||
| @Override | ||
| public void visitIndexed(JCArrayAccess tree) { | ||
| boolean previewIsIndexed = isIndexed; |
| // Field may not have an initializer | ||
| if ((sym.flags() & HASINIT) != 0) { | ||
| reportPrologueError(tree, sym, true); | ||
| if (!sym.type.hasTag(ARRAY) || !isIndexed) { |
There was a problem hiding this comment.
Does this work for complex ones like (this.a = stuff)[b] = 5?
Maybe we can try updating isInLHS to point to a JCTree and all the tests to be something like tree == isInLHS so this just won't run for array indexed trees?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still a work in progress
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1664/head:pull/1664$ git checkout pull/1664Update a local copy of the PR:
$ git checkout pull/1664$ git pull https://git.openjdk.org/valhalla.git pull/1664/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1664View PR using the GUI difftool:
$ git pr show -t 1664Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1664.diff