Skip to content

Conversation

MrSimms
Copy link
Member

@MrSimms MrSimms commented Oct 7, 2025

Use the correct constant


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8369260: [lworld] InnerClassLambdaMetafactory.java should use PREVIEW_MINOR_VERSION (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1665/head:pull/1665
$ git checkout pull/1665

Update a local copy of the PR:
$ git checkout pull/1665
$ git pull https://git.openjdk.org/valhalla.git pull/1665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1665

View PR using the GUI difftool:
$ git pr show -t 1665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1665.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2025

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369260: [lworld] InnerClassLambdaMetafactory.java should use PREVIEW_MINOR_VERSION

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2025

Webrevs

@MrSimms
Copy link
Member Author

MrSimms commented Oct 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

Going to push as commit b789fa9.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2025
@openjdk openjdk bot closed this Oct 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@MrSimms Pushed as commit b789fa9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant