Update pandoc docker image from 3.2 to 3.6.3#100
Draft
cthoyt wants to merge 4 commits intoopenjournals:mainfrom
Draft
Update pandoc docker image from 3.2 to 3.6.3#100cthoyt wants to merge 4 commits intoopenjournals:mainfrom
cthoyt wants to merge 4 commits intoopenjournals:mainfrom
Conversation
2 tasks
1f4deaa to
2093b0d
Compare
2093b0d to
283c520
Compare
Contributor
Author
|
@xuanxu do you think you could take a look at this? It's strange that the compilation the test job works but the example PDF workflow does not |
Contributor
Author
|
I think the issue is that latex needs to run twice, and it is erroring the first time when it hasn't taken a pass that it makes the citations https://github.com/openjournals/inara/actions/runs/13244251628/job/36966750145?pr=100#step:4:5417 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
The new version of pandoc causes the following minor changes in latex output:
Tables - tables are now sized with
\linewidthinstead of\columnwidth. This affects the tables captionedBasic inline markup and examplesandComparison of programming languages used in the publishing toolInline Images - the width of the nyan-cat image and sylt images are now determined by the
\linewidthinstead of\textwidth. Inline images now get thekeepaspectratioflagFree-standing Images - the mandrill image is now wrapped with
\pandocbounded{}. Free-standing images now get thekeepaspectratioflag.This command was introduced in Pandoc in jgm/pandoc@26b25a4 and lives in https://github.com/jgm/pandoc/blob/786356ace43d622866041f021b09452441ced009/data/templates/common.latex#L99-L108 in Pandoc 3.6.3. This requires adding the corresponding command to Inara's latex template
Blockers
It appears that two pre-existing issues that were suppressed by pandoc 3.2 are now causing failures for pandoc 3.6 (or at least, obscuring other errors that are happening with 3.6), so it would be nice to address these first in isolation:
example.md#104example.md#102 / Fix table reference inexample.md#103